From 41c5b7452752fb94d60f2aef48a621c529050a17 Mon Sep 17 00:00:00 2001
From: maelstrom <maelstrom@maelstrom.dev>
Date: Sat, 12 Jul 2025 11:20:31 +0200
Subject: [PATCH] feat(editor): click on stack trace to go to line in script

---
 editor/mainwindow.cpp            | 6 +++++-
 editor/mainwindow.h              | 2 +-
 editor/panes/outputtextview.cpp  | 8 +++++---
 editor/script/scriptdocument.cpp | 7 +++++++
 editor/script/scriptdocument.h   | 1 +
 5 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/editor/mainwindow.cpp b/editor/mainwindow.cpp
index 50306fa..5091a2f 100644
--- a/editor/mainwindow.cpp
+++ b/editor/mainwindow.cpp
@@ -610,19 +610,23 @@ ScriptDocument* MainWindow::findScriptWindow(std::shared_ptr<Script> script) {
     return nullptr;
 }
 
-void MainWindow::openScriptDocument(std::shared_ptr<Script> script) {
+void MainWindow::openScriptDocument(std::shared_ptr<Script> script, int line) {
     // Document already exists, don't open it
     ScriptDocument* doc = findScriptWindow(script);
     if (doc != nullptr) {
         ui->mdiArea->setActiveSubWindow(doc);
+        doc->setFocus();
+        if (line > -1) doc->moveCursor(line);
         return;
     }
 
     doc = new ScriptDocument(script);
     doc->setAttribute(Qt::WA_DeleteOnClose, true);
+    if (line > -1) doc->moveCursor(line);
     ui->mdiArea->addSubWindow(doc);
     ui->mdiArea->setActiveSubWindow(doc);
     doc->showMaximized();
+    doc->setFocus();
 }
 
 void MainWindow::closeScriptDocument(std::shared_ptr<Script> script) {
diff --git a/editor/mainwindow.h b/editor/mainwindow.h
index fcf4fb4..2f51d27 100644
--- a/editor/mainwindow.h
+++ b/editor/mainwindow.h
@@ -58,7 +58,7 @@ public:
     GridSnappingMode snappingMode;
     bool editSoundEffects = true;
 
-    void openScriptDocument(std::shared_ptr<Script>);
+    void openScriptDocument(std::shared_ptr<Script>, int line = -1);
     void closeScriptDocument(std::shared_ptr<Script>);
 
     void openFile(std::string path);
diff --git a/editor/panes/outputtextview.cpp b/editor/panes/outputtextview.cpp
index 885e464..af63871 100644
--- a/editor/panes/outputtextview.cpp
+++ b/editor/panes/outputtextview.cpp
@@ -60,7 +60,7 @@ void OutputTextView::handleLog(Logger::LogLevel logLevel, std::string message, L
         stackTraceScripts[id] = source.script;
 
         format.setAnchor(true);
-        format.setAnchorHref(QString::number(id));
+        format.setAnchorHref(QString::number(id) + ":" + QString::number(source.line));
     }
 
     cursor.insertText(message.c_str(), format);
@@ -72,11 +72,13 @@ void OutputTextView::mousePressEvent(QMouseEvent *e) {
     QString anchor = anchorAt(e->pos());
     if (anchor == "" || e->modifiers() & Qt::AltModifier) return QTextEdit::mousePressEvent(e);
 
-    auto script = stackTraceScripts[anchor.toInt()];
+    int idx = anchor.indexOf(":");
+    int id = anchor.mid(0, idx).toInt(), line = anchor.mid(idx+1).toInt();
+    auto script = stackTraceScripts[id];
     if (script.expired()) return QTextEdit::mousePressEvent(e);
 
     MainWindow* mainWnd = dynamic_cast<MainWindow*>(window());
-    mainWnd->openScriptDocument(script.lock());
+    mainWnd->openScriptDocument(script.lock(), line);
 }
 
 void OutputTextView::mouseReleaseEvent(QMouseEvent *e) {
diff --git a/editor/script/scriptdocument.cpp b/editor/script/scriptdocument.cpp
index 71a4735..fa7e84b 100644
--- a/editor/script/scriptdocument.cpp
+++ b/editor/script/scriptdocument.cpp
@@ -179,6 +179,13 @@ ScriptDocument::ScriptDocument(std::shared_ptr<Script> script, QWidget* parent):
 ScriptDocument::~ScriptDocument() {
 }
 
+void ScriptDocument::moveCursor(int line) {
+    if (line == -1) return;
+
+    int lineLength = scintilla->lineLength(line-1);
+    scintilla->setCursorPosition(line-1, lineLength-1);
+}
+
 QsciAPIs* makeApis(QsciLexer* lexer) {
     QsciAPIs* apis = new QsciAPIs(lexer);
 
diff --git a/editor/script/scriptdocument.h b/editor/script/scriptdocument.h
index 801d8ec..d001471 100644
--- a/editor/script/scriptdocument.h
+++ b/editor/script/scriptdocument.h
@@ -17,4 +17,5 @@ public:
     ~ScriptDocument() override;
 
     inline std::shared_ptr<Script> getScript() { return script; }
+    void moveCursor(int line);
 };
\ No newline at end of file