From 49f29b6af1ff7f28f51359cb3f77a7dcbdb76dd1 Mon Sep 17 00:00:00 2001 From: maelstrom Date: Mon, 26 May 2025 15:08:16 +0200 Subject: [PATCH] fix(lua): signal functions were being deleted after being called --- core/src/datatypes/signal.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/src/datatypes/signal.cpp b/core/src/datatypes/signal.cpp index ac46f1a..70522c2 100644 --- a/core/src/datatypes/signal.cpp +++ b/core/src/datatypes/signal.cpp @@ -23,7 +23,6 @@ LuaSignalConnection::LuaSignalConnection(lua_State* L, std::weak_ptr par // Save function so it doesn't get GC'd function = luaL_ref(L, LUA_REGISTRYINDEX); - lua_pop(L, 1); } LuaSignalConnection::~LuaSignalConnection() { @@ -36,7 +35,6 @@ void LuaSignalConnection::Call(std::vector args) { // Push function lua_rawgeti(thread, LUA_REGISTRYINDEX, function); - luaL_unref(thread, LUA_REGISTRYINDEX, function); for (Data::Variant arg : args) { arg.PushLuaValue(thread);