editor/mainglwidget.cpp

@@ -2,19 +2,11 @@
 #include <chrono>
 
 #include <QMouseEvent>
-#include <glm/ext/matrix_projection.hpp>
-#include <glm/ext/vector_float3.hpp>
-#include <glm/geometric.hpp>
-#include <glm/matrix.hpp>
-#include <reactphysics3d/collision/RaycastInfo.h>
-#include <vector>
 
 #include "GLFW/glfw3.h"
-#include "physics/util.h"
 #include "qcursor.h"
 #include "qevent.h"
 #include "qnamespace.h"
-#include "qwindowdefs.h"
 #include "rendering/renderer.h"
 #include "physics/simulation.h"
 #include "camera.h"
@@ -58,44 +50,11 @@ void MainGLWidget::mouseMoveEvent(QMouseEvent* evt) {
     // QCursor::setPos(lastMousePos);
 }
 
-class FirstRayHit : public rp::RaycastCallback {
-    rp::Body** target;
-
-    virtual rp::decimal notifyRaycastHit(const rp::RaycastInfo& raycastInfo) override {
-        if (reinterpret_cast<Part*>(raycastInfo.body->getUserData())->name == "Baseplate") return 1;
-
-        *target = raycastInfo.body;
-        return 0;
-    }
-
-public:
-    FirstRayHit(rp::Body** target) : target(target) {}
-};
-
 void MainGLWidget::mousePressEvent(QMouseEvent* evt) {
-    switch(evt->button()) {
+    if (evt->button() != Qt::RightButton) return;
-    // Camera drag
-    case Qt::RightButton: {
-        lastMousePos = evt->pos();
-        isMouseDragging = true;
-        return;
-    // Clicking on objects
-    } case Qt::LeftButton: {
-        QPoint position = evt->pos();
-        rp::Body* rayHitTarget = NULL;
 
-        glm::vec3 pointDir = camera.getScreenDirection(glm::vec2(position.x(), position.y()), glm::vec2(width(), height()));
+    lastMousePos = evt->pos();
-        castRay(camera.cameraPos, pointDir, 50000, new FirstRayHit(&rayHitTarget));
+    isMouseDragging = true;
-        if (!rayHitTarget) return;
-        std::shared_ptr<Part> part = partFromBody(rayHitTarget);
-        
-        //part.selected = true;
-        setSelection(std::vector<InstanceRefWeak> { part });
-
-        return;
-    } default:
-        return;
-    }
 }
 
 void MainGLWidget::mouseReleaseEvent(QMouseEvent* evt) {

editor/panes/explorermodel.cpp

@@ -71,10 +71,6 @@ QModelIndex ExplorerModel::toIndex(InstanceRef item) {
     return QModelIndex{};
 }
 
-QModelIndex ExplorerModel::ObjectToIndex(InstanceRef item) {
-    return toIndex(item);
-}
-
 QModelIndex ExplorerModel::parent(const QModelIndex &index) const {
     if (!index.isValid())
         return {};

editor/panes/explorermodel.h

@@ -41,7 +41,6 @@ public:
     Qt::DropActions supportedDragActions() const override;
     Qt::DropActions supportedDropActions() const override;
     InstanceRef fromIndex(const QModelIndex index) const;
-    QModelIndex ObjectToIndex(InstanceRef item);
 private:
     InstanceRef rootItem;
     QModelIndex toIndex(InstanceRef item);

editor/panes/explorerview.cpp

@@ -1,7 +1,6 @@
 #include "explorerview.h"
 #include "explorermodel.h"
 #include "common.h"
-#include "objects/base/instance.h"
 #include "qabstractitemmodel.h"
 #include "qaction.h"
 #include "qnamespace.h"
@@ -28,15 +27,6 @@ ExplorerView::ExplorerView(QWidget* parent):
         contextMenu.exec(this->viewport()->mapToGlobal(point));
     });
 
-    addSelectionListener([&](auto oldSelection, auto newSelection, bool fromExplorer) {
-        this->clearSelection();
-        for (InstanceRefWeak inst : newSelection) {
-            if (inst.expired()) continue;
-            QModelIndex index = this->model.ObjectToIndex(inst.lock());
-            this->selectionModel()->select(index, QItemSelectionModel::SelectionFlag::Select);
-        }
-    });
-
     buildContextMenu();
 }
 

src/camera.cpp

@@ -1,5 +1,4 @@
 #include "camera.h"
-#include <glm/ext/matrix_clip_space.hpp>
 #include <glm/ext/matrix_transform.hpp>
 
 Camera::Camera(glm::vec3 initalPosition) {
@@ -54,19 +53,3 @@ void Camera::processRotation(float deltaX, float deltaY) {
     if(pitch < -89.0f)
         pitch = -89.0f;
 }
-
-glm::vec3 Camera::getScreenDirection(glm::vec2 screenPos, glm::vec2 screenSize) {
-    // VVV Thank goodness for this person's answer
-    // https://stackoverflow.com/a/30005258/16255372
-
-    // glm::vec3 worldPos = camera.cameraPos + glm::vec3(glm::vec4(float(position.x()) / width() - 0.5f, float(position.y()) / height() - 0.5f, 0, 0) * camera.getLookAt());
-    glm::mat4 projection = glm::perspective(glm::radians(45.f), (float)screenSize.x / (float)screenSize.y, 0.1f, 100.0f);
-    glm::mat4 view = glm::lookAt(glm::vec3(0), this->cameraFront, this->cameraUp);
-    glm::mat4 inverseViewport = glm::inverse(projection * view);
-
-    glm::vec2 ndc = glm::vec2(screenPos.x / screenSize.x * 2.f - 1.f, -screenPos.y / screenSize.y * 2.f + 1.f);
-    glm::vec4 world = glm::normalize(inverseViewport * glm::vec4(ndc, 1, 1));
-    //glm::vec3 flat = glm::vec3(world) / world.w; // https://stackoverflow.com/a/68870587/16255372
-
-    return glm::vec3(world);
-}

src/camera.h

@@ -24,8 +24,7 @@ public:
     Camera(glm::vec3 initialPosition);
 
     glm::mat4 getLookAt();
-    /** Converts a set of screen coords to a direction from the camera's pos */
-    glm::vec3 getScreenDirection(glm::vec2 screenPos, glm::vec2 screenSize);
     void processRotation(float deltaX, float deltaY);
     void processMovement(Direction direction, float deltaTime);
+
 };

src/common.cpp

@@ -7,24 +7,4 @@ Camera camera(glm::vec3(0.0, 0.0, 3.0));
 //std::vector<Part> parts;
 std::shared_ptr<Workspace> workspace = Workspace::New();
 std::optional<HierarchyPreUpdateHandler> hierarchyPreUpdateHandler;
-std::optional<HierarchyPostUpdateHandler> hierarchyPostUpdateHandler;
+std::optional<HierarchyPostUpdateHandler> hierarchyPostUpdateHandler;
-
-
-std::vector<InstanceRefWeak> currentSelection;
-std::vector<SelectionUpdateHandler> selectionUpdateHandlers;
-
-void setSelection(std::vector<InstanceRefWeak> newSelection, bool fromExplorer) {
-    for (SelectionUpdateHandler handler : selectionUpdateHandlers) {
-        handler(currentSelection, newSelection, fromExplorer);
-    }
-
-    currentSelection = newSelection;
-}
-
-const std::vector<InstanceRefWeak> getSelection() {
-    return currentSelection;
-}
-
-void addSelectionListener(SelectionUpdateHandler handler) {
-    selectionUpdateHandlers.push_back(handler);
-}

src/common.h

@@ -1,5 +1,4 @@
 #pragma once
-#include "objects/base/instance.h"
 #include "objects/workspace.h"
 #include "camera.h"
 #include <functional>
@@ -9,15 +8,10 @@ class Instance;
 // typedef std::function<void(std::shared_ptr<Instance> element, std::optional<std::shared_ptr<Instance>> newParent)> HierarchyUpdateHandler;
 typedef std::function<void(InstanceRef object, std::optional<InstanceRef> oldParent, std::optional<InstanceRef> newParent)> HierarchyPreUpdateHandler;
 typedef std::function<void(InstanceRef object, std::optional<InstanceRef> oldParent, std::optional<InstanceRef> newParent)> HierarchyPostUpdateHandler;
-typedef std::function<void(std::vector<InstanceRefWeak> oldSelection, std::vector<InstanceRefWeak> newSelection, bool fromExplorer)> SelectionUpdateHandler;
 
-// TEMPORARY COMMON DATA FOR VARIOUS INTERNAL COMPONENTS
+// TEMPORARY COMMON DATA FOR DIFFERENT INTERNAL COMPONENTS
 
 extern Camera camera;
 extern std::shared_ptr<Workspace> workspace;
 extern std::optional<HierarchyPreUpdateHandler> hierarchyPreUpdateHandler;
-extern std::optional<HierarchyPostUpdateHandler> hierarchyPostUpdateHandler;
+extern std::optional<HierarchyPostUpdateHandler> hierarchyPostUpdateHandler;
-
-void setSelection(std::vector<InstanceRefWeak> newSelection, bool fromExplorer = false);
-const std::vector<InstanceRefWeak> getSelection();
-void addSelectionListener(SelectionUpdateHandler handler);

src/objects/base/instance.cpp

@@ -38,19 +38,7 @@ Instance::Instance(InstanceType* type) {
 Instance::~Instance () {
 }
 
-// TODO: Test this
+void Instance::SetParent(std::optional<std::shared_ptr<Instance>> newParent) {
-bool Instance::ancestryContinuityCheck(std::optional<std::shared_ptr<Instance>> newParent) {
-    for (std::optional<std::shared_ptr<Instance>> currentParent = newParent; currentParent.has_value(); currentParent = currentParent.value()->GetParent()) {
-        if (currentParent.value() == this->shared_from_this())
-            return false;
-    }
-    return true;
-}
-
-bool Instance::SetParent(std::optional<std::shared_ptr<Instance>> newParent) {
-    if (!ancestryContinuityCheck(newParent))
-        return false;
-
     auto lastParent = GetParent();
     if (hierarchyPreUpdateHandler.has_value()) hierarchyPreUpdateHandler.value()(this->shared_from_this(), lastParent, newParent);
     // If we currently have a parent, remove ourselves from it before adding ourselves to the new one
@@ -68,7 +56,6 @@ bool Instance::SetParent(std::optional<std::shared_ptr<Instance>> newParent) {
     if (hierarchyPostUpdateHandler.has_value()) hierarchyPostUpdateHandler.value()(this->shared_from_this(), lastParent, newParent);
 
     this->OnParentUpdated(lastParent, newParent);
-    return true;
 }
 
 std::optional<std::shared_ptr<Instance>> Instance::GetParent() {
@@ -96,7 +83,6 @@ tl::expected<void, MemberNotFound> Instance::SetPropertyValue(std::string name,
     if (!meta) return tl::make_unexpected(MemberNotFound());
 
     meta->codec.write(value, meta->backingField);
-    if (meta->updateCallback) meta->updateCallback.value()(name);
 
     return {};
 }

src/objects/base/instance.h

@@ -35,8 +35,6 @@ private:
     std::vector<std::shared_ptr<Instance>> children;
 
     std::optional<std::vector<std::string>> cachedMemberList;
-
-    bool ancestryContinuityCheck(std::optional<std::shared_ptr<Instance>> newParent);
 protected:
     std::unique_ptr<MemberMap> memberMap;
 
@@ -50,7 +48,7 @@ public:
 
     // Instance is abstract, so it should not implement GetClass directly
     virtual InstanceType* GetClass() = 0;
-    bool SetParent(std::optional<std::shared_ptr<Instance>> newParent);
+    void SetParent(std::optional<std::shared_ptr<Instance>> newParent);
     std::optional<std::shared_ptr<Instance>> GetParent();
     inline const std::vector<std::shared_ptr<Instance>> GetChildren() { return children; }
 

src/objects/base/member.h

@@ -2,7 +2,6 @@
 
 #include "../../datatypes/base.h"
 #include "datatypes/meta.h"
-#include <functional>
 #include <map>
 #include <memory>
 #include <optional>
@@ -33,16 +32,10 @@ constexpr FieldCodec fieldCodecOf() {
     };
 }
 
-template <typename T>
-std::function<void(std::string name)> memberFunctionOf(void(T::*func)(std::string), T* obj) {
-    return std::bind(func, obj, std::placeholders::_1);
-}
-
 struct PropertyMeta {
     void* backingField;
     const Data::TypeInfo* type;
     FieldCodec codec;
-    std::optional<std::function<void(std::string name)>> updateCallback;
 };
 
 typedef std::variant<PropertyMeta> MemberMeta;

src/objects/part.cpp

@@ -4,7 +4,6 @@
 #include "objects/base/member.h"
 #include <memory>
 #include <optional>
-#include "physics/simulation.h"
 
 static InstanceType TYPE_ {
     .super = Instance::TYPE,
@@ -23,11 +22,12 @@ Part::Part(): Part(PartConstructParams {}) {
 }
 
 Part::Part(PartConstructParams params): Instance(&TYPE_), position(params.position), rotation(params.rotation),
-                                        scale(params.scale), material(params.material), anchored(params.anchored) {                      
+                                        scale(params.scale), material(params.material), anchored(params.anchored) {
+                                            
     this->memberMap = std::make_unique<MemberMap>(MemberMap {
         .super = std::move(this->memberMap),
         .members = {
-            { "Anchored", { .backingField = &anchored, .type = &Data::Bool::TYPE, .codec = fieldCodecOf<Data::Bool, bool>(), .updateCallback = memberFunctionOf(&Part::onUpdated, this) } }
+            { "Anchored", { .backingField = &anchored, .type = &Data::Bool::TYPE, .codec = fieldCodecOf<Data::Bool, bool>() } }
         }
     });
 }
@@ -46,8 +46,4 @@ void Part::OnParentUpdated(std::optional<std::shared_ptr<Instance>> oldParent, s
         this->rigidBody->setIsActive(newParent.has_value());
 
     // TODO: Sleeping bodies that touch this one also need to be updated
-}
-
-void Part::onUpdated(std::string property) {
-    syncPartPhysics(std::dynamic_pointer_cast<Part>(this->shared_from_this()));
 }

src/objects/part.h

@@ -22,7 +22,6 @@ struct PartConstructParams {
 class Part : public Instance {
 protected:
     void OnParentUpdated(std::optional<std::shared_ptr<Instance>> oldParent, std::optional<std::shared_ptr<Instance>> newParent) override;
-    void onUpdated(std::string);
 public:
     static InstanceType* TYPE;
 
@@ -31,7 +30,6 @@ public:
     glm::quat rotation = glm::identity<glm::quat>();
     glm::vec3 scale;
     Material material;
-    bool selected = false;
     
     bool anchored = false;
     rp::RigidBody* rigidBody = nullptr;

src/physics/simulation.cpp

@@ -2,14 +2,12 @@
 #include <glm/ext/matrix_float3x3.hpp>
 #include <glm/gtc/quaternion.hpp>
 #include <memory>
-#include <reactphysics3d/collision/RaycastInfo.h>
 #include <reactphysics3d/collision/shapes/BoxShape.h>
 #include <reactphysics3d/collision/shapes/CollisionShape.h>
 #include <reactphysics3d/components/RigidBodyComponents.h>
 #include <reactphysics3d/engine/EventListener.h>
 #include <reactphysics3d/engine/PhysicsCommon.h>
 #include <reactphysics3d/mathematics/Quaternion.h>
-#include <reactphysics3d/mathematics/Ray.h>
 #include <reactphysics3d/mathematics/Transform.h>
 #include <reactphysics3d/mathematics/Vector3.h>
 #include <reactphysics3d/memory/DefaultAllocator.h>
@@ -38,8 +36,6 @@ void simulationInit() {
     world = physicsCommon->createPhysicsWorld();
 
     world->setGravity(rp::Vector3(0, -196.2, 0));
-
-    world->setEventListener(&eventListener);
 }
 
 void syncPartPhysics(std::shared_ptr<Part> part) {
@@ -62,7 +58,7 @@ void syncPartPhysics(std::shared_ptr<Part> part) {
         part->rigidBody->addCollider(shape, rp::Transform());
     part->rigidBody->setType(part->anchored ? rp::BodyType::STATIC : rp::BodyType::DYNAMIC);
 
-    part->rigidBody->setUserData(&*part);
+    world->setEventListener(&eventListener);
 }
 
 void physicsStep(float deltaTime) {
@@ -79,9 +75,4 @@ void physicsStep(float deltaTime) {
         // part.rotation = glm::eulerAngles(rpToGlm(transform.getOrientation()));
         part->rotation = rpToGlm(transform.getOrientation());
     }
-}
-
-void castRay(glm::vec3 point, glm::vec3 rotation, float maxLength, rp::RaycastCallback* callback) {
-    rp::Ray ray(glmToRp(point), glmToRp(glm::normalize(rotation)) * maxLength);
-    world->raycast(ray, callback);
 }

src/physics/simulation.h

@@ -1,11 +1,8 @@
 #pragma once
 
 #include "../objects/part.h"
-#include <glm/ext/vector_float3.hpp>
 #include <memory>
-#include <reactphysics3d/collision/RaycastInfo.h>
 
 void simulationInit();
 void syncPartPhysics(std::shared_ptr<Part> part);
-void physicsStep(float deltaTime);
+void physicsStep(float deltaTime);
-void castRay(glm::vec3 point, glm::vec3 rotation, float maxLength, rp::RaycastCallback* callback);

src/physics/util.h

@@ -1,12 +1,9 @@
 #pragma once
 #include <glm/ext/vector_float3.hpp>
-#include <memory>
-#include <reactphysics3d/body/Body.h>
 #include <reactphysics3d/mathematics/Quaternion.h>
 #include <reactphysics3d/mathematics/Vector3.h>
 #include <reactphysics3d/mathematics/mathematics.h>
 #include <glm/ext.hpp>
-#include "objects/part.h"
 
 namespace rp = reactphysics3d;
 
@@ -24,10 +21,4 @@ inline glm::vec3 rpToGlm(rp::Vector3 vec) {
 
 inline glm::quat rpToGlm(rp::Quaternion quat) {
     return glm::quat(quat.w, quat.x, quat.y, quat.z);
-}
-
-inline std::shared_ptr<Part> partFromBody(rp::Body* body) {
-    Part* raw = reinterpret_cast<Part*>(body->getUserData());
-    std::shared_ptr<Part> shared = std::dynamic_pointer_cast<Part>(raw->shared_from_this());    
-    return shared;
 }