CMakeLists.txt

@@ -23,15 +23,14 @@ find_package(GLUT REQUIRED)
 include_directories(${GLUT_INCLUDE_DIRS})
 
 find_package(glfw3 REQUIRED)
-find_package(OpenGL)
-find_package(glm CONFIG REQUIRED)
-find_package(assimp REQUIRED)
-find_package(ReactPhysics3D REQUIRED)
-find_package(pugixml REQUIRED)
 
-# PkgConfig packages
+find_package(OpenGL)
-# find_package(PkgConfig REQUIRED)
+
-# pkg_check_modules(PUGIXML REQUIRED pugixml)
+find_package(glm CONFIG REQUIRED)
+
+find_package(assimp REQUIRED)
+
+find_package(ReactPhysics3D REQUIRED)
 
 file(MAKE_DIRECTORY bin)
 
@@ -40,7 +39,7 @@ include_directories("include")
 file(GLOB_RECURSE SOURCES "src/*.cpp" "src/*.h")
 add_library(openblocks ${SOURCES})
 set_target_properties(openblocks PROPERTIES OUTPUT_NAME "openblocks")
-target_link_libraries(openblocks ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} ${PUGIXML_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D pugixml::pugixml)
+target_link_libraries(openblocks ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D)
 
 # add_executable(client "client/src/main.cpp" $<TARGET_OBJECTS:openblocks>)
 # include_directories("src")

client/CMakeLists.txt

@@ -1,4 +1,4 @@
 
 add_executable(client "src/main.cpp" $<TARGET_OBJECTS:openblocks>)
 include_directories("../src")
-target_link_libraries(client ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D pugixml::pugixml)
+target_link_libraries(client ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D)

deps.txt

@@ -1,10 +0,0 @@
-glm
-opengl
-assimp
-sdl2
-glfw
-glut
-glew
-qt6
-reactphysics3d
-pugixml

editor/CMakeLists.txt

@@ -66,7 +66,7 @@ else()
     qt5_create_translation(QM_FILES ${CMAKE_SOURCE_DIR} ${TS_FILES})
 endif()
 
-target_link_libraries(editor PRIVATE Qt${QT_VERSION_MAJOR}::Widgets ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D pugixml::pugixml)
+target_link_libraries(editor PRIVATE Qt${QT_VERSION_MAJOR}::Widgets ${SDL2_LIBRARIES} ${GLEW_LIBRARIES} ${GLUT_LIBRARIES} OpenGL::GL OpenGL::GLU glfw glm::glm assimp ReactPhysics3D::ReactPhysics3D)
 
 # Qt for iOS sets MACOSX_BUNDLE_GUI_IDENTIFIER automatically since Qt 6.1.
 # If you are developing for iOS or macOS you should consider setting an

editor/mainglwidget.cpp

@@ -11,6 +11,7 @@
 #include <reactphysics3d/collision/RaycastInfo.h>
 #include <vector>
 
+#include "GLFW/glfw3.h"
 #include "physics/util.h"
 #include "qcursor.h"
 #include "qevent.h"

editor/mainwindow.cpp

@@ -14,8 +14,6 @@
 
 #include "common.h"
 #include "editorcommon.h"
-#include "objects/base/instance.h"
-#include "objects/datamodel.h"
 #include "physics/simulation.h"
 #include "objects/part.h"
 #include "qitemselectionmodel.h"
@@ -63,14 +61,6 @@ MainWindow::MainWindow(QWidget *parent)
             ui->actionToggleSimulation->setIcon(QIcon::fromTheme("media-playback-start"));
         }
     });
-
-    connect(ui->actionSave, &QAction::triggered, this, [&]() {
-        pugi::xml_document doc;
-        pugi::xml_node node = doc.append_child("openblocks");
-        workspace()->Serialize(&node);
-
-        doc.print(std::cout);
-    });
     
     // ui->explorerView->Init(ui);
 

editor/panes/propertiesmodel.cpp

@@ -1,20 +1,12 @@
 #include "propertiesmodel.h"
 #include "datatypes/base.h"
-#include "datatypes/cframe.h"
 #include "objects/base/member.h"
 #include "qnamespace.h"
 
 PropertiesModel::PropertiesModel(InstanceRef selectedItem, QWidget *parent)
     : QAbstractItemModel(parent)
     , selectedItem(selectedItem) {
-    this->propertiesList.reserve(selectedItem->GetProperties().size());
+    this->propertiesList = selectedItem->GetProperties();
-    for (std::string name : selectedItem->GetProperties()) {
-        PropertyMeta meta = selectedItem->GetPropertyMeta(name).value();
-        // Don't show CFrames in properties
-        if (meta.type == &Data::CFrame::TYPE) continue;
-
-        this->propertiesList.push_back(name);
-    }
 }
 
 PropertiesModel::~PropertiesModel() = default;

src/datatypes/base.cpp

@@ -2,10 +2,9 @@
 
 #define IMPL_WRAPPER_CLASS(CLASS_NAME, WRAPPED_TYPE, TYPE_NAME) Data::CLASS_NAME::CLASS_NAME(WRAPPED_TYPE in) : value(in) {} \
 Data::CLASS_NAME::~CLASS_NAME() = default; \
-Data::CLASS_NAME::operator const WRAPPED_TYPE() const { return value; } \
+Data::CLASS_NAME::operator WRAPPED_TYPE() { return value; } \
 const Data::TypeInfo Data::CLASS_NAME::TYPE = { .name = TYPE_NAME, }; \
-const Data::TypeInfo& Data::CLASS_NAME::GetType() const { return Data::CLASS_NAME::TYPE; }; \
+const Data::TypeInfo& Data::CLASS_NAME::GetType() const { return Data::CLASS_NAME::TYPE; };
-void Data::CLASS_NAME::Serialize(pugi::xml_node* node) const { node->text().set(std::string(this->ToString())); }
 
 Data::Base::~Base() {};
 
@@ -25,10 +24,6 @@ const Data::String Data::Null::ToString() const {
     return Data::String("null");
 }
 
-void Data::Null::Serialize(pugi::xml_node* node) const {
-    node->text().set("null");
-}
-
 const Data::String Data::Bool::ToString() const {
     return Data::String(value ? "true" : "false");
 }

src/datatypes/base.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <pugixml.hpp>
 #include <string>
 
 
@@ -9,12 +8,11 @@
 public: \
     CLASS_NAME(WRAPPED_TYPE); \
     ~CLASS_NAME(); \
-    operator const WRAPPED_TYPE() const; \
+    operator WRAPPED_TYPE(); \
     virtual const TypeInfo& GetType() const override; \
     static const TypeInfo TYPE; \
     \
     virtual const Data::String ToString() const override; \
-    virtual void Serialize(pugi::xml_node* node) const override; \
 };
 
 namespace Data {
@@ -29,7 +27,6 @@ namespace Data {
         virtual ~Base();
         virtual const TypeInfo& GetType() const = 0;
         virtual const Data::String ToString() const = 0;
-        virtual void Serialize(pugi::xml_node* node) const = 0;
     };
 
     class Null : Base {
@@ -40,7 +37,6 @@ namespace Data {
         static const TypeInfo TYPE;
 
         virtual const Data::String ToString() const override;
-        virtual void Serialize(pugi::xml_node* node) const override;
     };
 
     DEF_WRAPPER_CLASS(Bool, bool)

src/datatypes/cframe.cpp

@@ -40,7 +40,7 @@ Data::CFrame::CFrame(Data::Vector3 position, Data::Vector3 lookAt, Data::Vector3
 
 Data::CFrame::~CFrame() = default;
 const Data::TypeInfo Data::CFrame::TYPE = {
-    .name = "CoordinateFrame",
+    .name = "CFrame",
 };
 
 const Data::TypeInfo& Data::CFrame::GetType() const { return Data::Vector3::TYPE; };
@@ -79,21 +79,4 @@ Data::CFrame Data::CFrame::operator +(Data::Vector3 vector) const {
 
 Data::CFrame Data::CFrame::operator -(Data::Vector3 vector) const {
     return *this + -vector;
-}
+}
-
-// Serialization
-
-void Data::CFrame::Serialize(pugi::xml_node* node) const {
-    node->append_child("X").text().set(std::to_string(this->X()));
-    node->append_child("Y").text().set(std::to_string(this->Y()));
-    node->append_child("Z").text().set(std::to_string(this->Z()));
-    node->append_child("R00").text().set(std::to_string(this->rotation[0][0]));
-    node->append_child("R01").text().set(std::to_string(this->rotation[1][0]));
-    node->append_child("R02").text().set(std::to_string(this->rotation[2][0]));
-    node->append_child("R10").text().set(std::to_string(this->rotation[0][1]));
-    node->append_child("R11").text().set(std::to_string(this->rotation[1][1]));
-    node->append_child("R12").text().set(std::to_string(this->rotation[2][1]));
-    node->append_child("R20").text().set(std::to_string(this->rotation[0][2]));
-    node->append_child("R21").text().set(std::to_string(this->rotation[1][2]));
-    node->append_child("R22").text().set(std::to_string(this->rotation[2][2]));
-}

src/datatypes/cframe.h

@@ -31,7 +31,6 @@ namespace Data {
         static const TypeInfo TYPE;
 
         virtual const Data::String ToString() const override;
-        virtual void Serialize(pugi::xml_node* parent) const override;
 
         operator glm::mat4() const;
         operator rp::Transform() const;

src/datatypes/meta.cpp

@@ -5,10 +5,4 @@ Data::String Data::Variant::ToString() const {
     return std::visit([](auto&& it) {
         return it.ToString();
     }, this->wrapped);
-}
-
-void Data::Variant::Serialize(pugi::xml_node* node) const {
-    std::visit([&](auto&& it) {
-        it.Serialize(node);
-    }, this->wrapped);
 }

src/datatypes/meta.h

@@ -30,6 +30,5 @@ namespace Data {
         template <typename T> Variant(T obj) : wrapped(obj) {}
         template <typename T> T get() { return std::get<T>(wrapped); }
         Data::String ToString() const;
-        void Serialize(pugi::xml_node* node) const;
     };
 }

src/datatypes/vector.cpp

@@ -41,12 +41,4 @@ Data::Vector3 Data::Vector3::Cross(Data::Vector3 other) const {
 
 float Data::Vector3::Dot(Data::Vector3 other) const {
     return glm::dot(this->vector, other.vector);
-}
+}
-
-// Serialization
-
-void Data::Vector3::Serialize(pugi::xml_node* node) const {
-    node->append_child("X").text().set(std::to_string(this->X()));
-    node->append_child("Y").text().set(std::to_string(this->Y()));
-    node->append_child("Z").text().set(std::to_string(this->Z()));
-}

src/datatypes/vector.h

@@ -24,7 +24,6 @@ namespace Data {
         static Data::Vector3 ONE;
 
         virtual const Data::String ToString() const override;
-        virtual void Serialize(pugi::xml_node* node) const override;
 
         operator glm::vec3() const;
         operator rp::Vector3() const;

src/objects/base/instance.cpp

@@ -140,27 +140,4 @@ std::vector<std::string> Instance::GetProperties() {
 
     cachedMemberList = memberList;
     return memberList;
-}
-
-// Serialization
-
-void Instance::Serialize(pugi::xml_node* parent) {
-    pugi::xml_node node = parent->append_child("Item");
-    node.append_attribute("class").set_value(this->GetClass()->className);
-
-    // Add properties
-    pugi::xml_node propertiesNode = node.append_child("Properties");
-    for (std::string name : GetProperties()) {
-        PropertyMeta meta = GetPropertyMeta(name).value();
-        if (meta.flags & PropertyFlags::PROP_NOSAVE) continue; // This property should not be serialized. Skip...
-
-        pugi::xml_node propertyNode = propertiesNode.append_child(meta.type->name);
-        propertyNode.append_attribute("name").set_value(name);
-        GetPropertyValue(name)->Serialize(&propertyNode);
-    }
-
-    // Add children
-    for (InstanceRef child : this->children) {
-        child->Serialize(&node);
-    }
 }

src/objects/base/instance.h

@@ -11,7 +11,6 @@
 #include <map>
 #include <vector>
 #include <../include/expected.hpp>
-#include <pugixml.hpp>
 
 #include "member.h"
 
@@ -69,9 +68,6 @@ public:
     tl::expected<PropertyMeta, MemberNotFound> GetPropertyMeta(std::string name);
     // Returning a list of property names feels kinda janky. Is this really the way to go?
     std::vector<std::string> GetProperties();
-
-    // Serialization
-    void Serialize(pugi::xml_node* parent);
 };
 
 typedef std::shared_ptr<Instance> InstanceRef;

src/objects/base/member.h

@@ -16,26 +16,20 @@ struct FieldCodec {
 };
 
 template <typename T, typename U>
-constexpr FieldCodec fieldCodecOf() {
+void _writeCodec(Data::Variant source, void* destination) {
-    return FieldCodec {
+    *(U*)destination = (U)source.get<T>();
-        .write = [](Data::Variant source, void* destination) {
-            *(U*)destination = (U)source.get<T>();
-        },
-        .read = [](void* source) -> Data::Variant {
-            return T(*(U*)source);
-        },
-    };
 }
 
-template <typename T>
+template <typename T, typename U>
+Data::Variant _readCodec(void* source) {
+    return T(*(U*)source);
+}
+
+template <typename T, typename U>
 constexpr FieldCodec fieldCodecOf() {
     return FieldCodec {
-        .write = [](Data::Variant source, void* destination) {
+        .write = &_writeCodec<T, U>,
-            *(T*)destination = source.get<T>();
+        .read = &_readCodec<T, U>,
-        },
-        .read = [](void* source) -> Data::Variant {
-            return *(T*)source;
-        },
     };
 }
 
@@ -44,17 +38,11 @@ std::function<void(std::string name)> memberFunctionOf(void(T::*func)(std::strin
     return std::bind(func, obj, std::placeholders::_1);
 }
 
-enum PropertyFlags {
-    PROP_HIDDEN = 1 << 0, // Hidden from the editor
-    PROP_NOSAVE = 1 << 1, // Do not serialize
-};
-
 struct PropertyMeta {
     void* backingField;
     const Data::TypeInfo* type;
     FieldCodec codec;
     std::optional<std::function<void(std::string name)>> updateCallback;
-    PropertyFlags flags;
 };
 
 typedef std::variant<PropertyMeta> MemberMeta;

src/objects/part.cpp

@@ -8,42 +8,6 @@
 #include <optional>
 #include "physics/simulation.h"
 
-// template <typename T, typename U>
-// constexpr FieldCodec fieldCodecOf() {
-//     return FieldCodec {
-//         .write = [](Data::Variant source, void* destination) {
-//             *(U*)destination = (U)source.get<T>();
-//         },
-//         .read = [](void* source) -> Data::Variant {
-//             return T(*(U*)source);
-//         },
-//     };
-// }
-
-constexpr FieldCodec cframePositionCodec() {
-    return FieldCodec {
-        .write = [](Data::Variant source, void* destination) {
-            Data::CFrame* cframe = static_cast<Data::CFrame*>(destination);
-            *cframe = cframe->Rotation() + source.get<Data::Vector3>();
-        },
-        .read = [](void* source) -> Data::Variant {
-            return *static_cast<Data::CFrame*>(source);
-        },
-    };
-}
-
-constexpr FieldCodec cframeRotationCodec() {
-    return FieldCodec {
-        .write = [](Data::Variant source, void* destination) {
-            Data::CFrame* cframe = static_cast<Data::CFrame*>(destination);
-            *cframe = Data::CFrame::FromEulerAnglesXYZ(source.get<Data::Vector3>()) + cframe->Position();
-        },
-        .read = [](void* source) -> Data::Variant {
-            return static_cast<Data::CFrame*>(source)->ToEulerAnglesXYZ();
-        },
-    };
-}
-
 const InstanceType Part::TYPE = {
     .super = &Instance::TYPE,
     .className = "Part",
@@ -63,29 +27,8 @@ Part::Part(PartConstructParams params): Instance(&TYPE), cframe(Data::CFrame(par
     this->memberMap = std::make_unique<MemberMap>(MemberMap {
         .super = std::move(this->memberMap),
         .members = {
-            { "Anchored", {
+            { "Anchored", { .backingField = &anchored, .type = &Data::Bool::TYPE, .codec = fieldCodecOf<Data::Bool, bool>(), .updateCallback = memberFunctionOf(&Part::onUpdated, this) } },
-                .backingField = &anchored,
+            // { "Position", { .backingField = &position, .type = &Data::Vector3::TYPE, .codec = fieldCodecOf<Data::Vector3, glm::vec3>(), .updateCallback = memberFunctionOf(&Part::onUpdated, this) } }
-                .type = &Data::Bool::TYPE,
-                .codec = fieldCodecOf<Data::Bool, bool>(),
-                .updateCallback = memberFunctionOf(&Part::onUpdated, this)
-            } }, { "Position", {
-                .backingField = &cframe,
-                .type = &Data::Vector3::TYPE,
-                .codec = cframePositionCodec(),
-                .updateCallback = memberFunctionOf(&Part::onUpdated, this),
-                .flags = PropertyFlags::PROP_NOSAVE
-            } }, { "Rotation", {
-                .backingField = &cframe,
-                .type = &Data::Vector3::TYPE,
-                .codec = cframeRotationCodec(),
-                .updateCallback = memberFunctionOf(&Part::onUpdated, this),
-                .flags = PropertyFlags::PROP_NOSAVE
-            } }, { "CFrame", {
-                .backingField = &cframe,
-                .type = &Data::CFrame::TYPE,
-                .codec = fieldCodecOf<Data::CFrame>(),
-                .updateCallback = memberFunctionOf(&Part::onUpdated, this),
-            } }
         }
     });
 }